Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix an incorrect metric #52111

Merged
merged 2 commits into from
Mar 27, 2024
Merged

lightning: fix an incorrect metric #52111

merged 2 commits into from
Mar 27, 2024

Conversation

wjhuang2016
Copy link
Member

What problem does this PR solve?

Issue Number: close #51947

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@wjhuang2016
done
1600a28 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

Merging #52111 (2c0202f) into master (311eef9) will decrease coverage by 15.9422%.
Report is 10 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #52111         +/-   ##
=================================================
- Coverage   70.6704%   54.7283%   -15.9422%     
=================================================
  Files          1486       1599        +113     
  Lines        439434     610726     +171292     
=================================================
+ Hits         310550     334240      +23690     
- Misses       109365     253275     +143910     
- Partials      19519      23211       +3692
Flag Coverage Δ
integration 36.7313% <66.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.6156% <66.6666%> (+5.7963%) ⬆️

lance6716
lance6716 reviewed Mar 26, 2024
View reviewed changes
br/pkg/lightning/backend/external/reader.go Outdated
@@ -63,6 +63,8 @@ func readAllData(
task.End(zap.ErrorLevel, err)
}()

output.size = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to move to ⬇️

tidb/br/pkg/lightning/backend/external/engine.go

Lines 326 to 329 in bd17acd

// release the reference of e.memKVsAndBuffers
e.memKVsAndBuffers.keys = nil
e.memKVsAndBuffers.values = nil
e.memKVsAndBuffers.memKVBuffers = nil

resetting these fields in one place

@wjhuang2016
refine
2c0202f 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 27, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 07:51:45.117331701 +0000 UTC m=+2054332.139578089: ☑️ agreed by ywqzzy.
  • 2024-03-27 07:56:14.436116643 +0000 UTC m=+2054601.458363031: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit e925628 into pingcap:master Mar 27, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect rate in grafana
3 participants
@wjhuang2016 @lance6716 @ywqzzy